Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pylint) == -> is #18207

Merged
merged 1 commit into from
Jun 20, 2024
Merged

(pylint) == -> is #18207

merged 1 commit into from
Jun 20, 2024

Conversation

Quexington
Copy link
Contributor

This was added in a PR and then a PR removing the ignore was added after. This fixes the pylint error.

@Quexington Quexington marked this pull request as ready for review June 18, 2024 21:22
@Quexington Quexington requested a review from a team as a code owner June 18, 2024 21:22
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 18, 2024
wjblanke
wjblanke approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9572414595

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.001%) to 90.878%
Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_node.py 1 88.94%
chia/introducer/introducer.py 1 78.26%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/_tests/core/util/test_lockfile.py 4 89.47%
chia/full_node/full_node.py 4 86.06%
chia/daemon/server.py 7 83.31%
Totals Coverage Status
Change from base Build 9571014256: 0.001%
Covered Lines: 100195
Relevant Lines: 110191
💛 - Coveralls

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jun 20, 2024
@cmmarslender cmmarslender merged commit ff30678 into main Jun 20, 2024
350 of 353 checks passed
@cmmarslender cmmarslender deleted the quex.pylint_callable_comparison branch June 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Quexington @wjblanke @emlowe @arvidn @cmmarslender