Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1451 Remove no longer needed TestWalletInterestedStore class #18621

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

As we're using pytest instead of unittest, this class isn't needed anymore.

Current Behavior:

Tests are grouped into a TestWalletInterestedStore class.

New Behavior:

Tests are no longer grouped into a TestWalletInterestedStore class.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Sep 23, 2024
@AmineKhaldi AmineKhaldi self-assigned this Sep 23, 2024
Copy link

Pull Request Test Coverage Report for Build 10992482258

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.966%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 82.43%
chia/_tests/core/full_node/test_transactions.py 1 99.14%
chia/full_node/full_node.py 1 86.94%
chia/timelord/timelord_launcher.py 2 70.55%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.02%
chia/rpc/rpc_server.py 3 87.83%
chia/wallet/wallet_node.py 9 88.37%
Totals Coverage Status
Change from base Build 10966863149: 0.03%
Covered Lines: 101966
Relevant Lines: 112070

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review September 23, 2024 15:43
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner September 23, 2024 15:43
@pmaslana pmaslana merged commit 75d6126 into Chia-Network:main Sep 24, 2024
371 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants