improve STRICT_ARGS_COUNT flag #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8264144526Details
💛 - Coveralls |
Rigidity
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
STRICT_ARGS_COUNTflag is used in mempool mode to restrict the number of arguments passed to conditions to just the one we support. i.e. no unknown arguments.There are some complicated rules around
AGG_SIG_MEandAGG_SIG_UNSAFE, since they never supported any additional parameters, not even in consensus mode. In the hard fork, this restriction will be lifted, and these conditions will behave like all other conditions. However, we still want to restrict the number of parameters used in mempool mode (just like other conditions)