Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python source folder and move sized ints and bytes classes #457

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Add Python source folder and move sized ints and bytes classes #457

merged 4 commits into from
Apr 9, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Apr 5, 2024

No description provided.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Apr 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8618462186

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.544%
Totals Coverage Status
Change from base Build 8570352988: 0.0%
Covered Lines: 11350
Relevant Lines: 13268
💛 - Coveralls

arvidn
arvidn reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the python code copied verbatim from chia-blockchain or did you have to make any tweaks?

wheel/generate_type_stubs.py Show resolved Hide resolved
@Rigidity
Copy link
Contributor Author

Rigidity commented Apr 8, 2024

was the python code copied verbatim from chia-blockchain or did you have to make any tweaks?

I didn't change anything yet. Figure that can be a separate PR. Need to port over the tests too

@Rigidity Rigidity marked this pull request as ready for review April 9, 2024 15:38
@Rigidity Rigidity requested a review from arvidn April 9, 2024 17:44
@Rigidity Rigidity merged commit 68b9d52 into main Apr 9, 2024
64 checks passed
@Rigidity Rigidity deleted the sized-pytypes branch April 9, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rigidity @arvidn