Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add high-level function to validate a merkle set proof #477

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 19, 2024

  • expose confirm_included_already_hashed() and confirm_not_included_already_hashed() to python.
  • make deserialize_proof() private and not exposed to python
  • extend tests, benchmark and fuzzer to cover the new function

The long term goal is to make validation of a proof not necessarily create MerkleSet object (or if it does, it's an implementation detail).

Copy link

coveralls-official bot commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8801260319

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.076%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/merkle_tree.rs 12 13 92.31%
Totals Coverage Status
Change from base Build 8800936962: 0.02%
Covered Lines: 11738
Relevant Lines: 13797

💛 - Coveralls

@arvidn arvidn force-pushed the validate-merkle-proof branch 2 times, most recently from 91e2fbc to 55e0162 Compare April 23, 2024 13:11
@matt-o-how matt-o-how merged commit f5d9b7c into main Apr 23, 2024
64 checks passed
@matt-o-how matt-o-how deleted the validate-merkle-proof branch April 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants