Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port UnfinishedHeaderBlock to Rust #479

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Port UnfinishedHeaderBlock to Rust #479

merged 2 commits into from
Apr 23, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity requested a review from arvidn April 22, 2024 12:15
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8783912880

Details

  • 0 of 31 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 85.677%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-protocol/src/header_block.rs 0 11 0.0%
crates/chia-protocol/src/unfinished_header_block.rs 0 20 0.0%
Totals Coverage Status
Change from base Build 8762038099: -0.2%
Covered Lines: 11694
Relevant Lines: 13649
💛 - Coveralls

arvidn
arvidn reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. It's not clear what the new conversion function is intended to be used for however.

crates/chia-protocol/src/header_block.rs Show resolved Hide resolved
@Rigidity Rigidity merged commit de52ebf into main Apr 23, 2024
64 checks passed
@Rigidity Rigidity deleted the unfinished-header-block branch April 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rigidity @arvidn