Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFT puzzle constructors #514

Merged
merged 1 commit into from
May 21, 2024
Merged

Add NFT puzzle constructors #514

merged 1 commit into from
May 21, 2024

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity requested a review from arvidn May 14, 2024 22:43
Copy link

Pull Request Test Coverage Report for Build 9087169035

Details

  • 0 of 88 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 83.647%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-puzzles/src/puzzles/nft.rs 0 88 0.0%
Totals Coverage Status
Change from base Build 9085195791: -0.5%
Covered Lines: 12010
Relevant Lines: 14358

💛 - Coveralls

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. Can you think of any ways to test or validate that these types produce the correct puzzle hashes? It seems you have somewhat of a protocol (with the name curry_tree_hash()). Perhaps a macro could generate a test that ensures the tree_hash() call generates the same hash as generating the full puzzle and tree-hashing it.

It might even be possible to have tests that execute (generated) puzzles with their (generated) solutions and ensure we get the conditions back that we expect.

crates/chia-puzzles/src/puzzles/nft.rs Show resolved Hide resolved
crates/chia-puzzles/src/puzzles/nft.rs Show resolved Hide resolved
@Rigidity Rigidity merged commit 0006112 into main May 21, 2024
64 checks passed
@Rigidity Rigidity deleted the nft-constructors branch May 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants