Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TEST_CONSTANTS to consensus constants #535

Merged
merged 6 commits into from
May 23, 2024
Merged

Add TEST_CONSTANTS to consensus constants #535

merged 6 commits into from
May 23, 2024

Conversation

matt-o-how
Copy link
Contributor

No description provided.

@matt-o-how matt-o-how requested a review from Rigidity May 22, 2024 17:35
Rigidity
Rigidity reviewed May 22, 2024
View reviewed changes
crates/chia-protocol/src/bytes.rs Outdated Show resolved Hide resolved
crates/chia-consensus/src/consensus_constants.rs Outdated Show resolved Hide resolved
Rigidity
Rigidity previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@Rigidity Rigidity requested a review from arvidn May 23, 2024 13:17
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9209062647

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.589%
Totals Coverage Status
Change from base Build 9204085638: 0.0%
Covered Lines: 12133
Relevant Lines: 14515
💛 - Coveralls

@matt-o-how matt-o-how merged commit 4a78212 into main May 23, 2024
64 checks passed
@matt-o-how matt-o-how deleted the test_constants branch May 23, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity left review comments

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-o-how @arvidn @Rigidity