Validate AGG_SIG_UNSAFE messages to not end in one of the banned suffixes #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
commented
May 31, 2024
Rigidity
reviewed
May 31, 2024
arvidn
force-pushed
the
agg-sig-suffix
branch
2 times, most recently
from
8bf06b8
to
c70b224
Compare
Pull Request Test Coverage Report for Build 9357723153Details
💛 - Coveralls |
Rigidity
previously approved these changes
Jun 3, 2024
…ixes as part of the condition parsing. Also, move the agg_sig_*_additional_data into ConsensusConstants, rather than being computed on-the-fly. This also requires ConsensusConstants to be passed in to run_block_generator and run_puzzle
Rigidity
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of the condition parsing.
The message of
AGG_SIG_UNSAFEconditions are not allowed to end with any of the suffixes used byAGG_SIG_*conditions (those suffixes are derived fromADDITIONAL_DATA, i.e. a unique identifier for the network).This is currently validated in
pkm_pairs()inchia-blockchain. This PR moves this validation into the condition parsing, to reject invalid conditions earlier. This requiresConsensusConstantsto be passed in to run_block_generator and run_puzzle.In
chia-blockchain, the suffixes for theAGG_SIG_*conditions are computed on-the-fly. This patch also move the agg_sig_*_additional_data into ConsensusConstants instead.