Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-880 Remove no longer needed debug in SpendBundle #591

Merged
merged 1 commit into from
Jul 3, 2024
Merged

CHIA-880 Remove no longer needed debug in SpendBundle #591

merged 1 commit into from
Jul 3, 2024

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi self-assigned this Jul 1, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9748894942

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 78.79%
Totals Coverage Status
Change from base Build 9645397669: 0.06%
Covered Lines: 11107
Relevant Lines: 14097
💛 - Coveralls

@Rigidity
Copy link
Contributor

Rigidity commented Jul 3, 2024

@AmineKhaldi can you rebase against main? The CI issue should be fixed

@AmineKhaldi
Copy link
Contributor Author

@AmineKhaldi can you rebase against main? The CI issue should be fixed

Done.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9775811853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 78.79%
Totals Coverage Status
Change from base Build 9767098610: 0.06%
Covered Lines: 11107
Relevant Lines: 14097
💛 - Coveralls

@Rigidity
Copy link
Contributor

Rigidity commented Jul 3, 2024

This just needs to be removed from the bindings in generate_type_stubs.py (then that script run to update the autogenerated file)

Otherwise lgtm

@AmineKhaldi
Copy link
Contributor Author

This just needs to be removed from the bindings in generate_type_stubs.py (then that script run to update the autogenerated file)

Otherwise lgtm

Done.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9778970146

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.1%) to 82.855%
Totals Coverage Status
Change from base Build 9767098610: 4.1%
Covered Lines: 11680
Relevant Lines: 14097
💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 3, 2024 14:18
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9780469420

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 78.79%
Totals Coverage Status
Change from base Build 9767098610: 0.06%
Covered Lines: 11107
Relevant Lines: 14097
💛 - Coveralls

@Rigidity Rigidity merged commit b1369f0 into Chia-Network:main Jul 3, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmineKhaldi @Rigidity