Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clvmr #635

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Update clvmr #635

merged 6 commits into from
Aug 5, 2024

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity marked this pull request as draft July 31, 2024 13:48
Copy link

Pull Request Test Coverage Report for Build 10181442806

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.0%) to 82.751%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-traits/src/streamable.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 10171556945: 2.0%
Covered Lines: 11667
Relevant Lines: 14099

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Aug 2, 2024

this looks good. is it ready for review and landing?

@Rigidity Rigidity marked this pull request as ready for review August 2, 2024 11:34
@Rigidity Rigidity requested a review from arvidn August 2, 2024 11:34
@Rigidity
Copy link
Contributor Author

Rigidity commented Aug 2, 2024

this looks good. is it ready for review and landing?

yeah I suppose it's ready - chia-bls is still using sha2 since I can't figure out how to implement hkdf for it though, but we can update that later

@Rigidity Rigidity merged commit 9e06845 into main Aug 5, 2024
65 checks passed
@Rigidity Rigidity deleted the update-clvmr branch August 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants