Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we have two copies of the u64_to_bytes() function (used in tests) #645

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 6, 2024

This patch deletes one of them.

Copy link

Pull Request Test Coverage Report for Build 10263283504

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 304 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+1.8%) to 80.785%

Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/classgroup.rs 1 0.0%
crates/chia-bls/src/error.rs 4 0.0%
crates/chia-bls/src/parse_hex.rs 6 70.0%
crates/chia-traits/src/streamable.rs 9 92.54%
crates/chia-bls/src/secret_key.rs 11 88.22%
crates/chia-bls/src/signature.rs 19 93.94%
crates/chia-bls/src/public_key.rs 19 89.9%
wheel/src/api.rs 43 67.02%
crates/chia-bls/src/bls_cache.rs 51 72.13%
crates/chia-bls/src/gtelement.rs 58 11.11%
Totals Coverage Status
Change from base Build 10260340941: 1.8%
Covered Lines: 11364
Relevant Lines: 14067

💛 - Coveralls

@arvidn arvidn merged commit b7d070a into main Aug 6, 2024
59 checks passed
@arvidn arvidn deleted the remove-redundant-function branch August 6, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants