Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port validate_clvm_and_signature() to rust #647

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 6, 2024

this is a cherry-pick of a minimal change from @matt-o-how 's PR to port validate_clvm_and_signature() to rust.

It turns out that this function is already not a drop-in replacement for the python implementation, so returning the GTElements as bytes doesn't really help that much.

Copy link

coveralls-official bot commented Aug 6, 2024

Pull Request Test Coverage Report for Build 10278877839

Details

  • 394 of 410 (96.1%) changed or added relevant lines in 3 files are covered.
  • 305 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-1.7%) to 81.35%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/gen/make_aggsig_final_message.rs 73 74 98.65%
crates/chia-consensus/src/spendbundle_validation.rs 320 321 99.69%
wheel/src/api.rs 1 15 6.67%
Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/classgroup.rs 1 0.0%
crates/chia-bls/src/error.rs 4 0.0%
crates/chia-bls/src/parse_hex.rs 6 70.0%
crates/chia-traits/src/streamable.rs 9 92.54%
crates/chia-bls/src/secret_key.rs 11 88.22%
crates/chia-bls/src/signature.rs 19 93.94%
crates/chia-bls/src/public_key.rs 19 89.9%
wheel/src/api.rs 44 61.52%
crates/chia-bls/src/bls_cache.rs 51 72.13%
crates/chia-bls/src/gtelement.rs 58 11.11%
Totals Coverage Status
Change from base Build 10265410447: -1.7%
Covered Lines: 11891
Relevant Lines: 14617

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review August 6, 2024 20:37
@arvidn arvidn marked this pull request as draft August 7, 2024 04:11
@arvidn arvidn marked this pull request as ready for review August 7, 2024 06:10
@arvidn arvidn merged commit 5f7b6cf into main Aug 7, 2024
59 checks passed
@arvidn arvidn deleted the port-validate-clvm branch August 7, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants