Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-1034 Rename Spend to SpendConditions and OwnedSpend to OwnedSpendConditions #656

Merged
merged 10 commits into from
Aug 13, 2024
Merged

CHIA-1034 Rename Spend to SpendConditions and OwnedSpend to OwnedSpendConditions #656

merged 10 commits into from
Aug 13, 2024

Conversation

matt-o-how
Copy link
Contributor

No description provided.

@matt-o-how matt-o-how requested a review from arvidn August 8, 2024 13:53
@arvidn arvidn changed the title Rename Spend to SpendConditions and OwnedSpend to OwnedSpendConditions CHIA-1034 Rename Spend to SpendConditions and OwnedSpend to OwnedSpendConditions Aug 9, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10371296007

Details

  • 84 of 84 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.851%
Totals Coverage Status
Change from base Build 10354660349: 0.0%
Covered Lines: 12295
Relevant Lines: 14663
💛 - Coveralls

arvidn
arvidn requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheel/python/chia_rs/chia_rs.pyi has line-ending changes, or someething

arvidn
arvidn approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's important to squash this PR when landing it

@matt-o-how matt-o-how merged commit 2e0331f into main Aug 13, 2024
58 checks passed
@matt-o-how matt-o-how deleted the rename_spend branch August 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-o-how @arvidn