Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup clippy warnings #705

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fixup clippy warnings #705

merged 1 commit into from
Sep 9, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Sep 9, 2024

altendky@p1 ~/r/chia_rs (main)> cargo clippy --workspace --all-features --all-targets
warning: adding items after statements is confusing, since items exist from the start of the scope
  --> crates/chia-consensus/src/spendbundle_conditions.rs:43:5
   |
43 |     const QUOTE_BYTES: usize = 2;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
   = note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`

warning: `chia-consensus` (lib) generated 1 warning
warning: adding items after statements is confusing, since items exist from the start of the scope
   --> crates/chia-consensus/src/spendbundle_conditions.rs:143:9
    |
143 |         const QUOTE_EXECUTION_COST: u64 = 20;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: adding items after statements is confusing, since items exist from the start of the scope
   --> crates/chia-consensus/src/spendbundle_conditions.rs:144:9
    |
144 |         const QUOTE_BYTE_COST: u64 = 2 * TEST_CONSTANTS.cost_per_byte;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: `chia-consensus` (lib test) generated 3 warnings (1 duplicate)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s

```rust
altendky@p1 ~/r/chia_rs (main)> cargo clippy --workspace --all-features --all-targets
warning: adding items after statements is confusing, since items exist from the start of the scope
  --> crates/chia-consensus/src/spendbundle_conditions.rs:43:5
   |
43 |     const QUOTE_BYTES: usize = 2;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements
   = note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`

warning: `chia-consensus` (lib) generated 1 warning
warning: adding items after statements is confusing, since items exist from the start of the scope
   --> crates/chia-consensus/src/spendbundle_conditions.rs:143:9
    |
143 |         const QUOTE_EXECUTION_COST: u64 = 20;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: adding items after statements is confusing, since items exist from the start of the scope
   --> crates/chia-consensus/src/spendbundle_conditions.rs:144:9
    |
144 |         const QUOTE_BYTE_COST: u64 = 2 * TEST_CONSTANTS.cost_per_byte;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements

warning: `chia-consensus` (lib test) generated 3 warnings (1 duplicate)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s
```
Copy link

Pull Request Test Coverage Report for Build 10773225541

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 83.953%

Totals Coverage Status
Change from base Build 10727507213: 0.002%
Covered Lines: 12373
Relevant Lines: 14738

💛 - Coveralls

@altendky altendky marked this pull request as ready for review September 9, 2024 13:28
@altendky altendky merged commit 5eeeda6 into main Sep 9, 2024
60 checks passed
@altendky altendky deleted the fixup_clippy_warnings branch September 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants