Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clvm to 0.9.0 #717

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Bump clvm to 0.9.0 #717

merged 2 commits into from
Sep 20, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 20, 2024

ENABLE_BLS_OPS_OUTSIDE_GUARD and ENABLE_FIXED_DIV have been removed in the new version of clvm_rs. Those features are now enabled unconditionally.

Some of the python tests imported chia-blockchain, which in turn depends on chia_rs. With this change, chia_rs no longer implements the exact same API, and so will fail those tests. Since we've had the rust-python fidelity tests running for a while now, we probably don't need them anymore. If we do, we should probably copy the old chia-blockchain code into the tests.

The python stub file was still mentioning ENABLE_BLS_OPS, ENABLE_SECP_OPS even though they were removed some time ago.

…y. fix an old mistake in the python stub file where some removed flags were still exposed.
…k with the new changes to chia_rs (since it's a circular dependency)
Copy link

Pull Request Test Coverage Report for Build 10966443853

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 82 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 83.373%

Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/block_record.rs 82 0.88%
Totals Coverage Status
Change from base Build 10948785887: -0.6%
Covered Lines: 12275
Relevant Lines: 14723

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review September 20, 2024 22:05
@arvidn arvidn merged commit f3548d8 into main Sep 20, 2024
60 checks passed
@arvidn arvidn deleted the bump-clvm-0.9.0 branch September 20, 2024 22:53
Copy link

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants