Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PySequence in BlsCache::update() #719

Merged
merged 1 commit into from
Sep 23, 2024
Merged

use PySequence in BlsCache::update() #719

merged 1 commit into from
Sep 23, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 23, 2024

in chia-blockchain we pass in a list of (bytes32, GTElement), and even though bytes32 is a bytes, the fact that the update() function takes a List means it's not covariant.

This is meant to fix that.

@arvidn arvidn marked this pull request as ready for review September 23, 2024 15:57
Copy link

Pull Request Test Coverage Report for Build 10997493863

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.303%

Totals Coverage Status
Change from base Build 10997285527: 0.0%
Covered Lines: 12378
Relevant Lines: 14859

💛 - Coveralls

@arvidn arvidn merged commit 38579c8 into main Sep 23, 2024
61 checks passed
@arvidn arvidn deleted the bls-update-sequence branch September 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants