Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used python block formatting and added block claim fees #258

Merged
merged 17 commits into from
Jan 18, 2022
Merged

Used python block formatting and added block claim fees #258

merged 17 commits into from
Jan 18, 2022

Conversation

jack60612
Copy link
Contributor

@jack60612 jack60612 commented Oct 31, 2021 •
edited
Loading

Solves #138

Requirements:

  • PR:9793 Needs to be merged into main.

@hoffmang9 hoffmang9 mentioned this pull request Nov 1, 2021
Closed
mariano54
mariano54 reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@mariano54 mariano54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested?
Also, i suggest adding a comment that says:
" an announcement consumed is required for full security against unbundling attacks"

@jack60612
Copy link
Contributor Author

Has this been tested? Also, i suggest adding a comment that says: " an announcement consumed is required for full security against unbundling attacks"

Currently not working after the last commit. Trying to find another similar solution

@jack60612
Copy link
Contributor Author

@mariano54 i revered it back to a working state and i will add the announcement soon

@jack60612 jack60612 changed the title Used python block formatting and added claim fees Used python block formatting and added block claim fees Jan 12, 2022
mariano54
mariano54 reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@mariano54 mariano54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it needs to be tested on testnet before merge.

yan74
yan74 reviewed Jan 16, 2022
View reviewed changes
pool/singleton.py Outdated Show resolved Hide resolved
@jack60612
Copy link
Contributor Author

Tested and ready!

mariano54
mariano54 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@mariano54 mariano54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for merge after corresponding chia-blochain PR is merged

@mariano54 mariano54 merged commit 7c8c80f into Chia-Network:main Jan 18, 2022
@mariano54 mariano54 mentioned this pull request Jan 18, 2022
Closed
@mssc89 mssc89 mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yan74 yan74 yan74 left review comments

@mariano54 mariano54 mariano54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack60612 @mariano54 @yan74