Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some elements are too close to the page borders #68

Open
Oxyrus opened this issue Jul 23, 2017 · 4 comments
Open

Some elements are too close to the page borders #68

Oxyrus opened this issue Jul 23, 2017 · 4 comments

Comments

@Oxyrus
Copy link

Oxyrus commented Jul 23, 2017

Issue Description & Expected Outcome:
I don't know if this is expected, but in my opinion some elements (see screenshots below) are too close to the page borders, giving them a little bit of space would make it look better.

My screen resolution is 1366x768.

  1. Footer logo
    http://i.imgur.com/IC9tnCK.png

  2. Comment box
    http://i.imgur.com/UZdiFFT.png

  3. Dashboard header icons
    http://i.imgur.com/mczoXPL.png

  4. Library header icons
    http://i.imgur.com/s8FF2k2.png

  5. User profile inputs
    http://i.imgur.com/TuI6Bff.png

Symptoms:
N/a

Steps to Recreate:
Visit the corresponding pages:

  1. Logo is present in every page http://devgaido.com/dashboard
  2. Comment box is present in any path http://devgaido.com/paths/srcctrl
  3. Dashboard header icons http://devgaido.com/dashboard
  4. Library header icons http://devgaido.com/library
  5. User profile inputs http://devgaido.com/profile

Resolution:
N/a

@Kornil
Copy link

Kornil commented Jul 23, 2017

This is an issue on desktop screen res, it was always pushed back but now it's time to give it a bit of priority.

@Oxyrus just for reference could you add your browser resolution?

@Oxyrus
Copy link
Author

Oxyrus commented Jul 23, 2017

@Kornil updated the issue, my resolution is 1366x768.

@elevenpassin
Copy link

Turns out this problem seems to be due to how the element styles are defined depending on the media queries. If the webpage is more than ~1430px or so, white space is given to make the content a little centered and more user friendly.
image

This seems to be applying for all the other elements in the page layout.
image

image

So there should be a single switch to the problem somewhere.

When the page width is less than ~1430px, the white space is totally gone.

image

image

image

Suggested Fix: I checked out a few elements via Dev tools and it turns out most of the elements do not have margin at all And also the header component is using padding to space data around, I've found that padding can act weird sometimes! Maybe you guys should add a little amount of margin to every element. :D

@jdmedlock
Copy link
Collaborator

Related to #76

@jdmedlock jdmedlock mentioned this issue Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants