Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL save | Issue since PR#264 #291

Closed
ChristianTremblay opened this issue Jul 28, 2021 · 6 comments
Closed

SQL save | Issue since PR#264 #291

ChristianTremblay opened this issue Jul 28, 2021 · 6 comments

Comments

@ChristianTremblay
Copy link
Owner

I need to investigate as tests are failing with proposal.

@ChristianTremblay
Copy link
Owner Author

As stated in the commit, BAC0 will now create 2 columns for binary and multistate values. The default column gives the integer value and the supplemental column named with suffix _str will give the string interpretation of the value.

This is something I didn't want to loose especially when dealing with multistate values.

@kushan-26
Copy link
Contributor

This change would work well and allow better handling of multistate values. I have one question though; How will the resampling handle the supplemental column for string values?

@ChristianTremblay
Copy link
Owner Author

It takes the last one. "Mean" would make no sense.
Can you test it on your side and see if it works for you ?

Also, you can have a look to InfluxDB. I just add support for it and I think that for a lot of cases, this will bring a lot more than SQLite.

https://bac0.readthedocs.io/en/develop/database.html?highlight=influxdb

@kushan-26
Copy link
Contributor

I will test the update and let you know. Please allow me few days since I'll be travelling this week.

The influxDB support looks intriguing to me. I will definitely look into it. I've been looking into solutions on how to extract historicized data from remote devices.

@kushan-26
Copy link
Contributor

I tested this update and worked without any glitch. This setup will make data querying simpler. Thanks for implementing!

@ChristianTremblay
Copy link
Owner Author

Nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants