Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger needs Log.Exception method #1075

Closed
kianzarrin opened this issue Apr 9, 2021 · 0 comments · Fixed by #1076
Closed

Logger needs Log.Exception method #1075

kianzarrin opened this issue Apr 9, 2021 · 0 comments · Fixed by #1076
Labels
enhancement Improve existing feature
Milestone
11.6.0

Comments

@kianzarrin
Copy link
Collaborator

kianzarrin commented Apr 9, 2021 •
edited
Loading

it might be a bit confusing how to log exception, stack trace, inner exceptions, ... . better to do it in a centralized way.
also, this function should have the option to show error dialog.
@kianzarrin kianzarrin added enhancement Improve existing feature triage Awaiting issue categorisation and removed triage Awaiting issue categorisation labels Apr 9, 2021
@kianzarrin kianzarrin mentioned this issue Apr 9, 2021
Merged
@kianzarrin kianzarrin linked a pull request Apr 12, 2021 that will close this issue
harmon patcher continues on error #1076
Merged
kianzarrin added a commit that referenced this issue Apr 12, 2021
@kianzarrin
harmon patcher continues on error (#1076)
f4d55ae 
Harmony patcher continues on error (#1074).
Also, it logs which functions have been patched failed patching (#1075).
@originalfoo originalfoo added this to the 11.6.0 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing feature
Projects
None yet
Milestone
11.6.0
Development

Successfully merging a pull request may close this issue.

harmon patcher continues on error CitiesSkylinesMods/TMPE
2 participants
@originalfoo @kianzarrin