Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backspace does not delete vehicle restrictions as advertised #1126

Open
kianzarrin opened this issue Jun 13, 2021 · 5 comments
Open

backspace does not delete vehicle restrictions as advertised #1126

kianzarrin opened this issue Jun 13, 2021 · 5 comments
Labels
BUG Defect detected docs Documentation VEHICLE RESTRICTIONS Feature: Vehicle restrictions

Comments

@kianzarrin
Copy link
Collaborator

image
the hint in the picture above says backspace should reset vehicle restrictions but when I press backspace nothing happens.
when I press delete it resets everything.

@kianzarrin kianzarrin added BUG Defect detected docs Documentation VEHICLE RESTRICTIONS Feature: Vehicle restrictions labels Jun 13, 2021
@kianzarrin
Copy link
Collaborator Author

@kvakvs I remember you wrote some code about this?

@kvakvs
Copy link
Collaborator

kvakvs commented Jun 13, 2021

I wrote keyboard shortcuts code and probably touched code which checked Delete/Bkspace.
Many months ago. It is literally one IF operator.

@kianzarrin
Copy link
Collaborator Author

so should backspace reset rules or not? we need a unified policy.

@kvakvs
Copy link
Collaborator

kvakvs commented Jun 20, 2021

On Macbooks, Delete button does not exist. They have Backspace, and to press Delete, you must hold Fn and Backspace, hence for convenience we supported both keybinds for one function. Both should work, at least on Mac. Windows users do not care.

@originalfoo
Copy link
Member

originalfoo commented Dec 10, 2021

With vehicle restrictions and parking tools, there's no segment selection - so which segment does delete/backspace apply to?

Would need something like speed limits where there's a button to switch to eraser mode (or 'reset to default' to use speed tool terminology).

There was an idea about having an eraser button on main toolbar, but that would be icky in relation to any tools that have segment/node selection or their own UI which already has delete button.

Another option is that, without UI panel, del/backspace could switch to 'eraser mode' which would change mouse cursor to an eraser with OSD/tooltip explaining to user what to do (ie. click stuff to reset it). Right-click/Esc could potentially exit the eraser mode.

Edit: With respect to eraser mode (where mouse cursor changes), that could also be introduced to tools that use segment/node selection when no segment/node is selected. (if a node/segment selected, del/backspace just resets that selected item). Also, with the eraser mode, shift key (etc) could be used to apply erasing along a route / between junctions / etc.

Related: #38 , #42 , #692 , #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected docs Documentation VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
None yet
Development

No branches or pull requests

3 participants