Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RushHour code #350

Closed
originalfoo opened this issue Jun 1, 2019 · 7 comments
Closed

Remove RushHour code #350

originalfoo opened this issue Jun 1, 2019 · 7 comments
Labels
adjustments required An issue require some adjustments in code code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability
Milestone

Comments

@originalfoo
Copy link
Member

There's a bunch of code relating to a mod, RushHour that no longer exists (and Rush Hour 2 is obsolete too).

For example, in GlobalConfig.cs:

https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/blob/master/TLM/TLM/State/GlobalConfig.cs#L253-L280

That stuff can be ripped out as it's no longer relevant.

@dymanoid Is any of that relevant to Real Time?

@originalfoo originalfoo added adjustments required An issue require some adjustments in code technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability labels Jun 1, 2019
@dymanoid
Copy link
Contributor

dymanoid commented Jun 1, 2019

@aubergine10, Rush Hour still exists and can be subscribed to in the Workshop. This code seems to ensure the integration between Rush Hour's parking features and TM:PE's parking features.

Real Time doesn't manage the vehicles at all, so this code has absolutely no effect on Real Time.

@Sipke82
Copy link

Sipke82 commented Jun 1, 2019

That rush hour parking feature is what i ment in #298

@originalfoo
Copy link
Member Author

Did Rush Hour II have those features? I thought it was only the older one which is kaput?

@dymanoid
Copy link
Contributor

dymanoid commented Jun 1, 2019

Yes, you're right. Rush Hour II has no car parking logic anymore. Just checked it.

@originalfoo
Copy link
Member Author

Considering #298 we could convert it in to an option user interface or the global xml.

Will pause this until after the harmony update is complete.

@originalfoo originalfoo added the ⏸Paused Paused for now label Jun 1, 2019
@VictorPhilipp
Copy link
Collaborator

As far as I remember I removed the Rush Hour compatibility code in the harmony branch

@originalfoo originalfoo removed ⏸Paused Paused for now labels Jul 16, 2019
@originalfoo originalfoo added this to the 11.0 milestone Aug 12, 2019
@originalfoo
Copy link
Member Author

Confirmed the obsolete code was removed as part of migration to harmony.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adjustments required An issue require some adjustments in code code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Development

No branches or pull requests

4 participants