Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod checker should always check for other TM:PE #434

Closed
originalfoo opened this issue Jul 18, 2019 · 2 comments · Fixed by #443
Closed

Mod checker should always check for other TM:PE #434

originalfoo opened this issue Jul 18, 2019 · 2 comments · Fixed by #443
Assignees
Labels
COMPATIBILITY Mod (in)compatibility / checker enhancement Improve existing feature in-progress The problem is being solved currently technical Tasks that need to be performed in order to improve quality and maintainability
Milestone

Comments

@originalfoo
Copy link
Member

Currently, if user turns off mod checker, it won't check for other TM:PE

That can cause the save/load issues we are all familiar with.

I'll update it to always check for TM:PE, but only check other mods (incompatible_mods.txt) if the user has enabled checks on startup.

@originalfoo originalfoo added feature A new distinct feature triage Awaiting issue categorisation enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability and removed feature A new distinct feature triage Awaiting issue categorisation labels Jul 18, 2019
@originalfoo originalfoo self-assigned this Jul 18, 2019
@originalfoo originalfoo added this to the 11.0 milestone Jul 18, 2019
@kvakvs
Copy link
Collaborator

kvakvs commented Jul 19, 2019

I suggest that TM:PE should shut down if other TM:PEs are detected, and either the most stable would remain running, or all of them shut down.

@originalfoo
Copy link
Member Author

If there are more than one TM:PE, regardless of whether enabled or not, it will still cause problems. See #211, particularly Dymanoid's comments.

@originalfoo originalfoo added the in-progress The problem is being solved currently label Jul 19, 2019
@originalfoo originalfoo added the COMPATIBILITY Mod (in)compatibility / checker label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMPATIBILITY Mod (in)compatibility / checker enhancement Improve existing feature in-progress The problem is being solved currently technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants