LeftHandDrive returns Right hand drive

[kianzarrin]

Currently Left hand drive is implemented like this:

        public bool LeftHandDrive =>
            Singleton<SimulationManager>.instance.m_metaData.m_invertTraffic
            == SimulationMetaData.MetaBool.True;

I suppose who ever wrote this confused left hand drive with left hand traffic.

I suggest the following fix.

        //make this [Obsolete]
        public bool LeftHandDrive => LeftHandTraffic; // Intentionally wrong for legacy reasons.

        public bool LeftHandTraffic =>
            Singleton<SimulationManager>.instance.m_metaData.m_invertTraffic
            == SimulationMetaData.MetaBool.True;

I didn't remove Left hand drive because I don't want to make too many changes in the code. note that the variable names may also need an update.

[originalfoo]

Rather than have something intentionally wrong, why not just do a find and replace across the entire source of the mod?

Also, I think it would be much less ambiguous if it was named TrafficDrivesOnLeft to divest from the often confused terms such as LHT/RHD vs. RHT/LHD.

[kianzarrin]

@aubergine10 you will need to search and replace a lot of variable names too.

[originalfoo]

I think it will be worth doing, to avoid future confusion. We (well, kvakvs specifically) did a lot of similar code clean up shortly after migration to Harmony framework just to improve overall maintainability of the codebase.

[originalfoo]

I can have a look at doing the bulk update later today, if you want?

[kianzarrin]

@aubergine10 that would be nice.