Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayIndexOutOfRange when Lane Arrow Tool enabled #606

Closed
krzychu124 opened this issue Jan 6, 2020 · 3 comments · Fixed by #607
Closed

ArrayIndexOutOfRange when Lane Arrow Tool enabled #606

krzychu124 opened this issue Jan 6, 2020 · 3 comments · Fixed by #607
Assignees
@krzychu124
Labels
11 ALPHA TM:PE v11 alpha edition BUG Defect detected confirmed Represents confirmed issue or bug high priority Affects lots of users LANE ROUTING Feature: Lane arrows / connectors Overlays Overlays, data vis, etc.
Milestone
11.0

Comments

@krzychu124
Copy link
Member

Describe the problem

I found a bug related to hoveredSegmentsId and hoveredNodeId, both values are currently used for rendering overlay when user hover mouse cursor above segment (indication of lane arrows can be changed).
Current Alpha version throws ArrayIndexOutOfRange because hoveredSegment is not connected to hoveredNode (ExtSegmentEndManager.GetIndex(ushort segmentId, ushort nodeId) returns -1). It's clearly raycasting issue.

Steps to reproduce

See gif below.

"Video"

node_segment_connection

Notes

My current fix returns false from HasHoverLaneArrows if ExtSegmentEndManager.GetIndex(segmentId, nodeId) equals -1 - node is not part of segment.
I will create PR later tomorrow.

BTW, I think I fixed cursor flickering (needs more tests) - easily visible on animation above
@krzychu124 krzychu124 added BUG Defect detected high priority Affects lots of users confirmed Represents confirmed issue or bug 11 ALPHA TM:PE v11 alpha edition LANE ROUTING Feature: Lane arrows / connectors Overlays Overlays, data vis, etc. labels Jan 6, 2020
@krzychu124 krzychu124 added this to the 11.0 milestone Jan 6, 2020
@krzychu124 krzychu124 self-assigned this Jan 6, 2020
@gamer78374
Copy link

just ran into this bug tonight! glad u know what's going on.

@krzychu124 krzychu124 mentioned this issue Jan 7, 2020
Merged
@originalfoo
Copy link
Member

It's going to be few more days before my gaming rig is repaired (freaking hardware nightmare) - should I revert v11 alpha workshop to alpha10 release in the interim?

@krzychu124
Copy link
Member Author

Ohh.. I forgot that you can revert version with one click. I am not really sure in which version half-segment overlays were introduced. I will fix PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzychu124 krzychu124

Labels
11 ALPHA TM:PE v11 alpha edition BUG Defect detected confirmed Represents confirmed issue or bug high priority Affects lots of users LANE ROUTING Feature: Lane arrows / connectors Overlays Overlays, data vis, etc.
Projects
None yet
Milestone
11.0
Development

Successfully merging a pull request may close this issue.

Add additional check if hovered node and segments are connected, CitiesSkylinesMods/TMPE
3 participants
@originalfoo @gamer78374 @krzychu124