-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V11 - Could not load type 'TrafficManager.Traffic.Data.VehicleState' from assembly 'TrafficManager` #649
Comments
@SevenQM as I explained in comments on workshop item , it's the other mod which is dependent on TM:PE. I suspect it's Tagging @pcfantasy |
Both CSUR_TMPE_Laneconnector_Fix and Advanced Junction Rule is obsolete. CSUR_TMPE_Laneconnector_Fix is never published and it is for CSUR beta3. please use CSUR ToolBox in steam. Advanced Junction Rule is removed from steam. Please delete it. |
@pcfantasy Can we incorporate that code (now in the CSUR ToolBox) direct in to TMPE? I assume it's to deal with lane connector issues on nodeless junctions? We have same issue for RWY (Railway) nodeless tracks and a few other networks too... |
@aubergine10 Yes, in CheckSegmentsTurningAngle, TMPE will check if (turningAngle < 1f) if turningAngle < 1f and dirDotProd > turningAngle; then return false to prevent some lane connectors. Sometimes for some reasons, asset owner will create some roads which turningAngle is not 1f. So I just return true for all CSUR roads to allow all lane connectors. |
@kianzarrin Could you incorporate that in to the stuff you're doing with lane connectors? |
@aubergine10 That review is already getting too big and out of hand. why not to do this in a separate pull request. It is not conflicting with my code. |
I am on this. I will also fix CSUR toolbox. EDIT: WAIT IF CSUR wants to be compatible with previous TMPE versions it should check version string right? what version should it check? |
Actually Ill just check for existence of : PS: who ever wrote this code has a really wide screan! Loader.Detours.Add(new Loader.Detour(Assembly.Load("TrafficManager").GetType("TrafficManager.UI.SubTools.LaneConnectorTool").GetMethod("CheckSegmentsTurningAngle", BindingFlags.NonPublic | BindingFlags.Instance, null, new Type[] { typeof(ushort), typeof(NetSegment).MakeByRefType(), typeof(bool), typeof(ushort), typeof(NetSegment).MakeByRefType(), typeof(bool) }, null),
typeof(NewLaneConnectorTool).GetMethod("CheckSegmentsTurningAngle", BindingFlags.NonPublic | BindingFlags.Instance, null, new Type[] { typeof(ushort), typeof(NetSegment).MakeByRefType(), typeof(bool), typeof(ushort), typeof(NetSegment).MakeByRefType(), typeof(bool) }, null))); |
I suggest to return true for all roads. Why do we need to check turningAngle to allow lane connector for road, only railway need this I think, |
Can you please give me an example outside of CSUR? |
Can you help explain something about turningAngle? |
maxTurningAngle < 90 degrees is necessary for implementing continuous median toggled by traffic lights. For example, when traffic lights are turned off for a T-junction of CSUR roads, the median and markings on the straight road is not broken so that one does not have to plop medians and markings manually to achieve such effect as in vanilla roads. Specifically, the continuous median is a direct connect node triggered by a connect group (e.g., WideTram and NarrowTram), and most CSUR roads have connect group originally designed for trains and at-grade tram intersections. This leads to the need of setting an acute maxTurningAngle for continuous medians, because the maxTurningAngle is the maximum angle by which the game tries to create direct connect nodes. In vanilla roads, the maxTurningAngle is 90°. This allows for making rail transit networks above or on the road turn at an intersection. In the screenshot above the turning angle of monorail is exactly 90° in the left and slightly larger than 90° in the right. Because the maxTurningAngle is 90°, the monorail is connected through a direct connect road only in the left. Therefore, if the maxTurningAngle=90 is used for continuous median (right road in the above screenshot), one obtains a similar effect as is expected for a monorail/tram intersection. However, in this case the desired effect is the median of the branched road comes to an end right before the intersection (left road in the above screenshot), and this has to be achieved by setting maxTurningAngle < 90. In CSUR roads, we set maxTurningAngle=75 (maxTurningAngleCos=0.2588) to allow for some flexibility in the intersection angle. Outside of CSUR, the earliest road assets implementing continuous median also have maxTurningAngle < 90, for example: |
To solve #649 (comment) I made exception for unconnected tracks: |
The TMPE side is fixed(shortly will put a pull request)
Can I rely on this to be |
OK,I will update this too. |
I think the We could add a separate property to the |
Just realised @kianzarrin Change it to number but provide some way to include string bolt ons in the stuff that gets shown to user (eg. |
@aubergine10
I prefer to use Version class. // usage example
new Version(11.1,blah,blah)
version.ToString(2) //major and minor only
version1 > version2 // it has internal comparison And I will get public static string VersionString => ModVersion.ToString(2);
public static Version ModVersion => typeof(TrafficManagerMod).Assembly.GetName().Version; Hopefully no one has used |
detecting median is not part of this issue but rather its part of #243 |
A beta is being pushed to LABS page that does not yet contian CSUR fix. The beta will be versioned The CSUR update will be in next beta, version 11.1.1. For more details see #687 |
@SevenQM Please let us know if the issue is fixed or not. |
Describe the problem
After the V11 update, I entered the game as before, and an error message popped up。
Could not load type 'TrafficManager.Traffic.Data.VehicleState' from assembly 'TrafficManager, Version=1.0.7026.40416, Culture=neutral, PublicKeyToken=null'. [System.TypeLoadException]
Details:
No details
I subscribed to the V11LABS version. No other subscriptions. There is no problem returning 10.20. Find solution: subscribe to V11 and subscribe to 10.20, the problem will only disappear when V11 is enabled
Steps to reproduce
Log files
Savegame?
https://steamcommunity.com/sharedfiles/filedetails/?id=1988175689
Screenshots?
Notes or questions?
TMPE.log
output_log.txt
The text was updated successfully, but these errors were encountered: