Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StayInLane gets confused with multi pupose car/track lanes. #705

Open
kianzarrin opened this issue Feb 16, 2020 · 6 comments
Open

StayInLane gets confused with multi pupose car/track lanes. #705

kianzarrin opened this issue Feb 16, 2020 · 6 comments
Labels
BUG Defect detected LANE ROUTING Feature: Lane arrows / connectors low priority Issue with low priority of work
Milestone
Road vs. Track di...

Comments

@kianzarrin
Copy link
Collaborator

kianzarrin commented Feb 16, 2020 •
edited
Loading

see #705 (comment)

This part is fixed:
Screenshot (514)
This is because the innerSimilarIndex of the track matches the innerSimilarIndex of the road.
There has to be extra check using the CanConnect function that I recently introduced.
@kianzarrin kianzarrin added BUG Defect detected triage Awaiting issue categorisation labels Feb 16, 2020
@kianzarrin kianzarrin added this to the Road vs. Track distinction milestone Feb 16, 2020
This was referenced Feb 16, 2020
Closed
Merged
@kianzarrin
Copy link
Collaborator Author

This issue should fix #703 too.
Asymmetrical tracks/max turning angle would be particularly challenging.

@kianzarrin
Copy link
Collaborator Author

simple track fix:
Screenshot (522)
Screenshot (519)
Screenshot (520)

It still can get confused with asymmetrical tracks and mixed track/road stuff.
track roads are not part of the lane Arithmetic of quick-fix.

Stay In lane is mostly solved though. Still needs test for edge cases.

kianzarrin added a commit to kianzarrin/Cities-Skylines-Traffic-Manager-President-Edition that referenced this issue Feb 16, 2020
@kianzarrin
Lane connection :parttially mitigated CitiesSkylinesMods#705 by check…
d265949 
…ing CanConnect() for tracks.

include same sized oneway road.
@originalfoo originalfoo added LANE ROUTING Feature: Lane arrows / connectors and removed triage Awaiting issue categorisation labels Feb 17, 2020
@kianzarrin kianzarrin changed the title StayInLane connects tracks to roads StayInLane gets confused with multi pupose car/track lanes. Feb 19, 2020
@kianzarrin
Copy link
Collaborator Author

Result from #706 : There is nothing wrong with the picture bellow.
Screenshot (618)

Is this issue resolved for all practical purposes? I guess if both roads have mixed tram+car lanes this this gets confused but I cannot find such a road.

@kianzarrin
Copy link
Collaborator Author

Ill make this issue low priority until someone encounters the problem in practice.

@kianzarrin kianzarrin added the low priority Issue with low priority of work label Feb 28, 2020
@originalfoo
Copy link
Member

Just to clarify, is this where a lane supports both road+tracked at same time (like vanilla) but not where a track lane is placed above a separate road lane?

@kianzarrin
Copy link
Collaborator Author

Mixed bag!

kianzarrin added a commit that referenced this issue Apr 7, 2020
@kianzarrin
Merge pull request #706 from kianzarrin/703-laneconnector-quickfix
66ee727 
fixes #703 
- stay in lane on junctions (lanes do not crisscross). 
- When lane arithmetic does not match lanes connections are distributed evenly. the remainder goes to inner/other/center lanes depending  on circumstances.
- guide message is shown when nothing happens.
- changed shortcut key to CTRL+S (which conflicts with mod tools).
- I fixed a problem with stay in lane when stay in lane : when stayInLaneMode == None selected node markers disappeared.
- I added simple CanConnect() Condition for tracks which mostly solves #705. Asymmetrical tracks and mixed car/tram roads are still unsupported. 
fixes #617
- stay in lane does not connect if there is only one lane: #617
krzychu124 added a commit that referenced this issue Apr 7, 2020
@krzychu124
Merge pull request #706 from kianzarrin/703-laneconnector-quickfix
f497723 
fixes #703
- stay in lane on junctions (lanes do not crisscross).
- When lane arithmetic does not match lanes connections are distributed evenly. the remainder goes to inner/other/center lanes depending  on circumstances.
- guide message is shown when nothing happens.
- changed shortcut key to CTRL+S (which conflicts with mod tools).
- I fixed a problem with stay in lane when stay in lane : when stayInLaneMode == None selected node markers disappeared.
- I added simple CanConnect() Condition for tracks which mostly solves #705. Asymmetrical tracks and mixed car/tram roads are still unsupported.
fixes #617
- stay in lane does not connect if there is only one lane: #617
@ian76g ian76g mentioned this issue Apr 15, 2022
Closed
@kianzarrin kianzarrin mentioned this issue Apr 27, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Defect detected LANE ROUTING Feature: Lane arrows / connectors low priority Issue with low priority of work
Projects
None yet
Milestone
Road vs. Track distinction
Development

No branches or pull requests
2 participants
@originalfoo @kianzarrin