-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove decorative and non-vehicle networks from speed limits manager. #513
Conversation
First commit ensures that non-vehicle networks (eg. decorative networks) and bicycle paths are skipped in the speed limit manager. Fixes #510 Second commit will add some logging either side of null netinfos to hopefully make source of them easier to track down (I suspect it's something to do with NExt2 or MOM). #Fixes #378
Hopefully we can then track down their source.
Interesting note: This asset in workshop, which apparently works as a road, reports https://steamcommunity.com/sharedfiles/filedetails/?id=1398431305 |
Actually, there's a few other reporting improvements to make here - brb |
Testing extended logging, found another road that doesn't specify vehicle types: https://steamcommunity.com/sharedfiles/filedetails/?id=1399095368 Same author. I'm in his discord server so I'll let him know direct. |
The check for
|
Added a bunch of extra logging to the NetInfo scanner so we get more detail about any problems (will be useful to asset creators for example). One of the log messages (that checks for applicalbe `m_netAI`) was spammy so added a new debug switch `SpeedLimits` to toggle that on and off.
Added a bunch of extra logging to the NetInfo scanner so we get more detail about any problems (will be useful to asset creators for example). One of the log messages (that checks for applicalbe With new debug switch we could probably revisit the various Speed Limit classes at some later date to see if any other logging merits being toggled with that switch. Anyway, let me know what you think of the latest commit. |
Looks like document auto-format also un-indented |
|
- Replaced a delegate with a lambda - Moved some stuff based on IDE suggestions - Completed a few obvious code comments Most of the remaining IDE warnings are about code comments, although there are a few things like "use private instead of internal" up near top of class.
Added notes for asset creators about requirements for ensuring their roads work with speed limits tool: |
First commit ensures that non-vehicle networks (eg. decorative networks) and bicycle paths are skipped in the speed limit manager.
Fixes #510
Second commit adds some logging either side of null NetInfo warnings to hopefully make source of them easier to track down (I suspect it's something to do with NExt2 or MOM).
#Fixes #378