Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null reference OnEnable - hotfix #570

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Null reference OnEnable - hotfix #570

merged 1 commit into from
Nov 23, 2019

Conversation

krzychu124
Copy link
Member

Partial fix for #563

I wrapped code inside if because OnEnable is called automatically(by Unity) every time when tool is going to be enabled. On first call that dictionary of TM:PE subtools does not exist yet

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug labels Nov 23, 2019
@krzychu124 krzychu124 added this to the 11.0 milestone Nov 23, 2019
@krzychu124 krzychu124 self-assigned this Nov 23, 2019
originalfoo
originalfoo approved these changes Nov 23, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krzychu124 krzychu124 merged commit b4cb705 into master Nov 23, 2019
@originalfoo originalfoo deleted the null-reference-onEnabled-fix branch November 23, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected confirmed Represents confirmed issue or bug
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@krzychu124 @originalfoo