Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get SCM vertical levels from namelist file instead of .nc simulation file. #69

Closed
haakon-e opened this issue Oct 26, 2021 · 6 comments
Closed
Assignees

Comments

@haakon-e
Copy link
Member

No description provided.

@haakon-e
Copy link
Member Author

This would imply that scm_path points directly to a namelist file instead of a simulation directory.

@haakon-e haakon-e added enhancement New feature or request Refactor ⚙️ and removed enhancement New feature or request labels Oct 29, 2021
@haakon-e
Copy link
Member Author

haakon-e commented Nov 4, 2021

Two approaches:

  1. For non-isotropic domains, a TC namelist file will still define parameters for some function that generates vertical levels. Instead of running a simulation, we can generate these vertical levels using TC functions along with parameters from a namelist file
  2. Run a simulation for 1 timestep (linked to Allow setting SCM runtimetf from calibration pipeline. #71), then fetch vertical levels with existing methods.

@ilopezgp
Copy link
Contributor

ilopezgp commented Nov 4, 2021

We need to:

  • Read z_scm (grid),
  • Namelist (to modify parameters and generate runs),
  • Location of TC.jl variables (z_c or z_f) without running a full simulation.

@charleskawczynski had some ideas of how this might be done without even running the simulation for a single time step.

@charleskawczynski
Copy link
Member

Can call stuff defined in TC.jl's integration_test/ folder?

@charleskawczynski
Copy link
Member

If so, we could use:

sim = Simulation1d(namelist)

for variable_name in keys(sim.io_nt.aux)
    space = sim.io_nt.aux[variable_name].dims[1]
    # One of these will be true:
    # space == "zf"
    # space == "zc"
end

This will be subject to change, but it should work without actually simulating any steps.

@ilopezgp
Copy link
Contributor

Fixed in #87 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants