Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: run short simulation for reference SCM #87

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

haakon-e
Copy link
Member

@haakon-e haakon-e commented Nov 5, 2021

Explicitly fetch/generate namelist from TC, then modify the time step in the namelist so that reference SCM simulation is only run 1 step forward. This generates the necessary z-levels, and cell/face variable info for calibration.

Depends on CliMA/TurbulenceConvection.jl#525.

TODO: Check that TC doesn't write namelist to output directory, otherwise all calibration studies will have incorrect t_max.

@haakon-e haakon-e force-pushed the short_sim_refactor branch 3 times, most recently from 407329b to 0188c72 Compare November 18, 2021 05:43
@ilopezgp ilopezgp marked this pull request as ready for review November 18, 2021 18:51
@ilopezgp
Copy link
Contributor

The scm_pycles_pipeline experiment fails for me on central using this branch,

┌ Warning: No unique stats netCDF file found in │ scm_init/Output.Bomex.000000/stats. Extending search to other files. └ @ CalibrateEDMF.TurbulenceConvectionUtils /central/home/ilopezgo/CalibrateEDMF.jl/src/helper_funcs.jl:218 ┌ Warning: Extended search errored with: │ Base.IOError("readdir(\"scm_init/Output.Bomex.000000/stats\"): no such │ file or directory (ENOENT)", -2)

@haakon-e
Copy link
Member Author

The scm_pycles_pipeline experiment fails for me on central using this branch,

┌ Warning: No unique stats netCDF file found in │ scm_init/Output.Bomex.000000/stats. Extending search to other files. └ @ CalibrateEDMF.TurbulenceConvectionUtils /central/home/ilopezgo/CalibrateEDMF.jl/src/helper_funcs.jl:218 ┌ Warning: Extended search errored with: │ Base.IOError("readdir(\"scm_init/Output.Bomex.000000/stats\"): no such │ file or directory (ENOENT)", -2)

Yeah, I'll have to look into this a bit closer. The warnings themselves are fine -- I added them because readdir errors if the directory doesn't exist (at least on HPC) -- but I think readdir is a fix for Windows systems, so I don't know what the subtleties are here...

Anyways, there's also a test that's failing which relates to les driven cases, which is not surprising that it fails -- but it's surprising because I didn't change that code... I'll investigate and see if I understand what's going on this afternoon.

@ilopezgp
Copy link
Contributor

The scm_pycles_pipeline experiment fails for me on central using this branch,
┌ Warning: No unique stats netCDF file found in │ scm_init/Output.Bomex.000000/stats. Extending search to other files. └ @ CalibrateEDMF.TurbulenceConvectionUtils /central/home/ilopezgo/CalibrateEDMF.jl/src/helper_funcs.jl:218 ┌ Warning: Extended search errored with: │ Base.IOError("readdir(\"scm_init/Output.Bomex.000000/stats\"): no such │ file or directory (ENOENT)", -2)

Yeah, I'll have to look into this a bit closer. The warnings themselves are fine -- I added them because readdir errors if the directory doesn't exist (at least on HPC) -- but I think readdir is a fix for Windows systems, so I don't know what the subtleties are here...

Anyways, there's also a test that's failing which relates to les driven cases, which is not surprising that it fails -- but it's surprising because I didn't change that code... I'll investigate and see if I understand what's going on this afternoon.

The LesDrivenSCM error might be due to the construction of the dirname and namelist paths, which is not the same as for any other case (there are functions that add a suffix). Maybe @costachris can see if there is an issue.

@ilopezgp
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 24, 2021

@bors bors bot merged commit da733ef into main Nov 24, 2021
@bors bors bot deleted the short_sim_refactor branch November 24, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical interpolation not working for profiles with a single time step
2 participants