-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: run short simulation for reference SCM #87
Conversation
407329b
to
0188c72
Compare
The
|
Yeah, I'll have to look into this a bit closer. The warnings themselves are fine -- I added them because Anyways, there's also a test that's failing which relates to les driven cases, which is not surprising that it fails -- but it's surprising because I didn't change that code... I'll investigate and see if I understand what's going on this afternoon. |
0188c72
to
1dc52ed
Compare
The LesDrivenSCM error might be due to the construction of the dirname and namelist paths, which is not the same as for any other case (there are functions that add a suffix). Maybe @costachris can see if there is an issue. |
1dc52ed
to
0188c72
Compare
9942132
to
291d581
Compare
291d581
to
93884b5
Compare
bors r+ |
Build succeeded: |
Explicitly fetch/generate namelist from TC, then modify the time step in the namelist so that reference SCM simulation is only run 1 step forward. This generates the necessary z-levels, and cell/face variable info for calibration.
Depends on CliMA/TurbulenceConvection.jl#525.
TODO: Check that TC doesn't write namelist to output directory, otherwise all calibration studies will have incorrect
t_max
.