Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cutoff microphysics in TRMM no longer supported? #1009

Closed
ilopezgp opened this issue May 18, 2022 · 2 comments · Fixed by #1010
Closed

cutoff microphysics in TRMM no longer supported? #1009

ilopezgp opened this issue May 18, 2022 · 2 comments · Fixed by #1010
Assignees
@trontrytel
Labels
bug Something isn't working

Comments

@ilopezgp
Copy link
Contributor

When running TRMM with cutoff microphysics, I get:

[1;23rODE   0%\|                                               \|  ETA: N/A
 Error: TurbulenceConvection simulation crashed. Stacktrace for failed
--
  | │ simulation
  | │   exception =
  | │    UndefVarError: rho_cloud_liq not defined
  | │    Stacktrace:
@ilopezgp ilopezgp added the bug Something isn't working label May 18, 2022
@charleskawczynski
Copy link
Member

I think we just need to replace TC.rho_cloud_liq with rho_cloud_liq in the diagnostics. But yeah, we should add this to our CI

@trontrytel
Copy link
Member

Yeah. I agree. I'm fixing it now and making sure it's in the CI

@trontrytel trontrytel mentioned this issue May 18, 2022
Merged
@ilopezgp ilopezgp linked a pull request May 18, 2022 that will close this issue
fix cutoff precipitation #1010
Merged
bors bot added a commit that referenced this issue May 18, 2022
@bors @trontrytel
Merge #1010
b4abfa8 
1010: fix cutoff precipitation r=trontrytel a=trontrytel

In response to issue #1009

This PR:
- fixes the `rho_cloud_liquid` problem by using the `CliMAParameters.jl` defined liquid water density
- adds TRMM + cutoff microphysics to Vanilla + Deviations tests in the buildkite CI
- renames `CutoffPrecipitation` precipitation model to `Clima0M` precipitation model. This is done to be more consistent with the notation used in the `CloudMicrophysics.jl` package.

Co-authored-by: Anna Jaruga <ajaruga@caltech.edu>
@bors bors bot closed this as completed in #1010 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trontrytel trontrytel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix cutoff precipitation CliMA/TurbulenceConvection.jl
3 participants
@trontrytel @charleskawczynski @ilopezgp