You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our extensive use of the dummy variable name kwargs hides bugs within the code. An instance can be found in driver/Cases.jl:
function surface_params(case::GABLS, surf_ref_state, param_set; kwargs...)
FT = eltype(surf_ref_state)
Tsurface = t -> 265.0 - (0.25 / 3600.0) * t
qsurface = 0.0
shf = 0.0001 # only prevent zero division in SF.jl lmo
lhf = 0.0001 # only prevent zero division in SF.jl lmo
# ustar = 0.1 # TODO: remove, this isn't actually used
zrough = 0.1
kwargs = (; Tsurface, qsurface, shf, lhf, zrough)
return TC.MoninObukhovSurface(FT; kwargs...)
end
Note that the kwargs passed to the returned structure do not contained the kwargs of surface_params. See PR #1013 for a print showing that we are taking the Richardson number as the default (why is there a default of 0?)
The text was updated successfully, but these errors were encountered:
Our extensive use of the dummy variable name
kwargs
hides bugs within the code. An instance can be found indriver/Cases.jl
:Note that the kwargs passed to the returned structure do not contained the kwargs of surface_params. See PR #1013 for a print showing that we are taking the Richardson number as the default (why is there a default of 0?)
The text was updated successfully, but these errors were encountered: