Remove reference state and move ref variables to grid mean #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/remove_ref_state
branch
5 times, most recently
from
58a1188
to
6693483
Compare
yairchn
commented
May 17, 2022
yairchn
force-pushed
the
yc/remove_ref_state
branch
8 times, most recently
from
b2a3cf4
to
35cc8cc
Compare
yairchn
force-pushed
the
yc/remove_ref_state
branch
from
35cc8cc
to
b56ce9d
Compare
bors bot
added a commit
that referenced
this pull request
May 18, 2022
1008: Provide two interfaces to compute ref state r=charleskawczynski a=charleskawczynski This PR will allow us to compute the reference state given several individual fields, or the TC state. This will help make #1004 easier. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
yairchn
force-pushed
the
yc/remove_ref_state
branch
9 times, most recently
from
4a4caf2
to
ba29a2b
Compare
charleskawczynski
approved these changes
May 19, 2022
yairchn
force-pushed
the
yc/remove_ref_state
branch
from
09ded2e
to
d3cf1a7
Compare
|
Let's squash before merging |
yairchn
force-pushed
the
yc/remove_ref_state
branch
6 times, most recently
from
8248fcb
to
086f628
Compare
yairchn
force-pushed
the
yc/remove_ref_state
branch
from
086f628
to
c37eb99
Compare
|
Bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RP removes the reference state from the model and moves the references variables to the grid mean.
pis added toaux_gmandaux_gm_fρis added toprog_gmandaux_gm_fαis removed completely from the model (use1/ρwhen instead).The grid mean
p,ρare initialized as the references state by assuming an hydrostatic balance and their tendencies are zero.This prepares the ground to having both Anelastic (constant
ρ) and compressible (time dependentρ) options when coupling to a global model.