set qt and h in extrap buoyancy to clear values #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/fix_buoy_extrap
branch
from
31a40cb
to
7210708
Compare
charleskawczynski
approved these changes
Aug 10, 2021
charleskawczynski
force-pushed
the
yc/fix_buoy_extrap
branch
from
7210708
to
d089c31
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 10, 2021
100: Move entr and detr to separate file r=charleskawczynski a=yairchn This PR moves the computation of entrainment and detrainment to a separate file - while breaking of the non dimensional functions so that they could replaced by NN or any time of ML in the future. Both this PR and the the recent changes to pressure should have all parameters read of CliMA parameters in the future 103: set qt and h in extrap buoyancy to clear values r=charleskawczynski a=yairchn First step to handle the definition of h and qt in extra buoyancy part in the updrafts Co-authored-by: yairchn <yairchn@caltech.edu>
trontrytel
reviewed
Aug 10, 2021
|
bors r- |
|
Canceled. |
yairchn
pushed a commit
that referenced
this pull request
Aug 10, 2021
set qt and h in extrap buoyancy to clear values fix change in qt issue use the correct qt and qv in extra bouy update tables fix tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to handle the definition of h and qt in extra buoyancy part in the updrafts