Use correct ClimaCore types and operators for horizontal velocities #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/cc_types2
branch
from
10c221d
to
d081749
Compare
yairchn
reviewed
Jun 14, 2022
yairchn
reviewed
Jun 14, 2022
yairchn
reviewed
Jun 14, 2022
yairchn
reviewed
Jun 14, 2022
yairchn
approved these changes
Jun 14, 2022
Use ClimaCore types session 2 Fix other cases Try reversing coriolis sign More fixes More fixes More fixes, and add set_z Widen arg types Fix LES_driven_SCM
charleskawczynski
force-pushed
the
ck/cc_types2
branch
from
d081749
to
5fdf64c
Compare
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jun 15, 2022
1180: Fix subtype bug, remove unused method definition r=charleskawczynski a=charleskawczynski This PR: - Removes an unused method, `set_z!`, which I forgot to remove in #1173. - Fixes a sub/super type bug: need to use `val isa AbstractString` in `print_repl_script`. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
(ug, vu) -> uₕ_g(sgs_flux_u,sgs_flux_v) -> sgs_flux_uₕ(diffusive_flux_u,diffusive_flux_v) -> diffusive_flux_uₕThere are some places where we'll need to revisit so that we're also compatible with topography, but it's probably best that we revisit that when we have something to test.