Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reference state to MSE. #1215

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Change reference state to MSE. #1215

merged 1 commit into from
Jun 28, 2022

Conversation

ilopezgp
Copy link
Contributor

@ilopezgp ilopezgp commented Jun 28, 2022

PULL REQUEST

Purpose and Content

  • Use the same reference state as the main version of TC.jl to prevent spurious behavior in deep convective cases.

I followed PR #1151, adding the necessary Thermodynamics functions that were added after version 0.7.1 of Thermodynamics.

@ilopezgp ilopezgp marked this pull request as ready for review June 28, 2022 20:17
@ilopezgp ilopezgp requested a review from trontrytel June 28, 2022 20:29
Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilopezgp
Copy link
Contributor Author

This PR fixes the deep convection behavior in TRMM-LBA. It also leads to changes at the inversion height in the LES_driven_SCM shallow case; the inversion becomes less smooth with these changes. I will make a release and test the deep/shallow behavior of the calibrated model in the LES_driven_SCM cases.

@ilopezgp
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 28, 2022

Build succeeded:

@bors bors bot merged commit a6f0c43 into theta-var Jun 28, 2022
@bors bors bot deleted the theta-var-ref-state branch June 28, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants