Separate the update and initialization in TurbulencePrognosticTKE #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/organize_rhs
branch
5 times, most recently
from
9eeb7da
to
98b5ecb
Compare
merge update and comput prognostic upd WIP unify first decom_env move init env cov to initialize_covariance move all initializations from update to init move all initialization componenets from update to initilize move all initialization componenets from update to initilize
yairchn
force-pushed
the
yc/organize_rhs
branch
from
98b5ecb
to
8a45796
Compare
yairchn
commented
Aug 17, 2021
| end | ||
| update_inversion(self, GMV, Case.inversion_option) | ||
| self.wstar = get_wstar(Case.Sur.bflux, self.zi) | ||
| microphysics(self.EnvThermo, self.EnvVar, self.Rain, TS.dt) |
There was a problem hiding this comment.
@trontrytel I think this microphysics call is needed - but I am not sure
There was a problem hiding this comment.
I will start by including it and maybe remove it later PR
yairchn
commented
Aug 18, 2021
| end | ||
| update_inversion(self, GMV, Case.inversion_option) | ||
| self.wstar = get_wstar(Case.Sur.bflux, self.zi) | ||
| microphysics(self.EnvThermo, self.EnvVar, self.Rain, TS.dt) |
There was a problem hiding this comment.
I will start by including it and maybe remove it later PR
| @@ -260,7 +279,8 @@ function update(self::EDMF_PrognosticTKE, GMV::GridMeanVariables, Case::CasesBas | |||
| buoyancy(self.UpdThermo, self.UpdVar, self.EnvVar, GMV, self.extrapolate_buoyancy) | |||
| compute_eddy_diffusivities_tke(self, GMV, Case) | |||
| update_GMV_ED(self, GMV, Case, TS) | |||
| compute_covariance(self, GMV, Case, TS) | |||
| compute_covariance_rhs(self, GMV, Case, TS) | |||
There was a problem hiding this comment.
here 'compute_covariance' was split into 'compute_covariance_rhs' and 'update_covariance' as these two functions will be called separately in a future PR
|
Bors r+ |
costachris
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am taking the first step to writing the model equations as RHS and LHS. To that end I am starting by taking anything relating initialization out of the update function in TurbulencePrognosticTKE.
Doing so, I found that some cases with variable ustar has zero ustar at the initialization which leads to nan in the surface covariances. To avoid this I added a ustar value for these cases that is over written by compute_ustar after initialization.
The PR has behavioral changes that are negligible to my opinion.