Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read entrainment parameters from param_set #137

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Conversation

yairchn
Copy link
Member

@yairchn yairchn commented Aug 17, 2021

No description provided.

@yairchn yairchn force-pushed the yc/entrainment_parameters branch 2 times, most recently from 7eb6a21 to f7a0680 Compare August 17, 2021 16:46
Copy link
Member

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start

integration_tests/utils/parameter_set.jl Show resolved Hide resolved
integration_tests/utils/parameter_set.jl Outdated Show resolved Hide resolved
integration_tests/utils/parameter_set.jl Show resolved Hide resolved
src/closures/entr_detr.jl Show resolved Hide resolved
src/closures/nondimensional_exchange_functions.jl Outdated Show resolved Hide resolved
name issues

name issues

remove in types.jl

fix conflicts and remove entr_sigma

WIP

fix bug EntrDetr output
Co-authored-by: Haakon Ludvig Langeland Ervik <45243236+haakon-e@users.noreply.github.com>
@haakon-e
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 17, 2021

@bors bors bot merged commit d41e8e3 into main Aug 17, 2021
@bors bors bot deleted the yc/entrainment_parameters branch August 17, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants