Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bcs with operators in upwind_advection_velocity #177

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Use bcs with operators in upwind_advection_velocity #177

merged 2 commits into from
Aug 29, 2021

Conversation

charleskawczynski
Copy link
Member

This PR:

  • Makes upwind_advection_velocity use bcs
  • Renames ∇_onesided -> c∇_onesided
  • defines f∇_onesided

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2021
@bors @charleskawczynski
Merge #177
56e6387 
177: Use bcs with operators in upwind_advection_velocity r=charleskawczynski a=charleskawczynski

This PR:
 - Makes upwind_advection_velocity use bcs
 - Renames `∇_onesided` -> `c∇_onesided`
 - defines `f∇_onesided`

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@charleskawczynski
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 29, 2021

Canceled.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 29, 2021
@bors @charleskawczynski
Merge #177
1ca0b47 
177: Use bcs with operators in upwind_advection_velocity r=charleskawczynski a=charleskawczynski

This PR:
 - Makes upwind_advection_velocity use bcs
 - Renames `∇_onesided` -> `c∇_onesided`
 - defines `f∇_onesided`

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 29, 2021

Build failed:

@charleskawczynski
Copy link
Member Author

The MSE tables needed to be updated, but the changes are minuscule.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 29, 2021

Build succeeded:

@bors bors bot merged commit a62df93 into main Aug 29, 2021
@bors bors bot deleted the ck/interp_ops branch August 29, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski