Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure main to have single update function #186

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

charleskawczynski
Copy link
Member

This PR restructures main.jl so that there is a single update function. This means that

        TC.zero_tendencies(self.GMV)
        Cases.update_surface(self.Case, self.GMV, self.TS)
        Cases.update_forcing(self.Case, self.GMV, self.TS)
        Cases.update_radiation(self.Case, self.GMV, self.TS)

        TC.update(self.GMV, self.TS)
        TC.update_GMV_diagnostics(self.Turb, self.GMV)

moves inside TC.update. This way, we can decompose TC.update into

  • Update aux (compute diagnostic and non-local quantities)
  • Compute RHS (compute tendencies, not new)
  • Solve eqs (values = values + Δt*tendencies + implicit solves)

@charleskawczynski
Copy link
Member Author

Results look fine

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

@bors bors bot merged commit 230dcd2 into main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant