Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dry/cloudy for unsat/sat. Change th/thv to \theta, \thetav. #433

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Change dry/cloudy for unsat/sat. Change th/thv to \theta, \thetav. #433

merged 1 commit into from
Oct 22, 2021

Conversation

ilopezgp
Copy link
Contributor

No description provided.

yairchn
yairchn approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trontrytel
trontrytel approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some quadrature points and comment in one of the closure models that could still be updated. Looks good otherwise.

src/EDMF_Environment.jl Show resolved Hide resolved
src/types.jl Show resolved Hide resolved
charleskawczynski
charleskawczynski reviewed Oct 21, 2021
View reviewed changes
src/types.jl Outdated Show resolved Hide resolved
@ilopezgp
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 22, 2021

Build succeeded:

@bors bors bot merged commit a9d7950 into main Oct 22, 2021
@bors bors bot deleted the new_notation branch October 22, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@yairchn yairchn yairchn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilopezgp @trontrytel @charleskawczynski @yairchn