Conservative variables in the updraft equations #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
force-pushed
the
yc/cons_prog
branch
2 times, most recently
from
766102a
to
6826e55
Compare
charleskawczynski
approved these changes
Oct 25, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2021
441: Conservative variables in the updraft equations r=charleskawczynski a=yairchn this PR changes the equations of the updraft to solve for conservative variables and updates the primitive values (which intertwine the equations to a separate function) only in Auxiliary variables. Co-authored-by: yairchn <yairchn@caltech.edu>
|
bors r- |
|
Canceled. |
|
Ah, I just realized, DryBubble is pretty broken with these changes. @yairchn, can you take a look? |
|
Awesome |
|
bors r+ |
|
Actually, something in that PR needs to be worked out. This should merge after it fails. |
bors bot
added a commit
that referenced
this pull request
Oct 25, 2021
441: Conservative variables in the updraft equations r=charleskawczynski a=yairchn this PR changes the equations of the updraft to solve for conservative variables and updates the primitive values (which intertwine the equations to a separate function) only in Auxiliary variables. Co-authored-by: yairchn <yairchn@caltech.edu>
|
Bors r+ |
|
Already running a review |
|
Build failed: |
|
bors r+ |
This was referenced Oct 26, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the equations of the updraft to solve for conservative variables and updates the primitive values (which intertwine the equations to a separate function) only in Auxiliary variables.