Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NA for new variable entries in mse computations #459

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Use NA for new variable entries in mse computations #459

merged 1 commit into from
Oct 27, 2021

Conversation

charleskawczynski
Copy link
Member

This PR changes some of the logic in computing the MSE: now, for new variables (i.e., variables that do not exist in any of the datasets), we use a string ("NA") for the computed/best MSE entries, which automatically pass (since there's no reference yet to compute an error from).

I believe that this should fix the issues with #395 adding ice.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 27, 2021

Build succeeded:

@bors bors bot merged commit 5bcd3d2 into main Oct 27, 2021
@charleskawczynski charleskawczynski mentioned this pull request Oct 27, 2021
Merged
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
5b2b0c9 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
293853a 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
091e9e3 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski referenced this pull request Nov 1, 2021
@bors @charleskawczynski
Merge #490
0f67537 
490: Bump version for new release r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Post processing ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski