Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more grid abstractions #46

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Use more grid abstractions #46

merged 1 commit into from
Jul 27, 2021

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jul 27, 2021 •
edited
Loading

  • Use more grid abstractions
  • Delete useless code
  • Add type constraints

@codecov
Copy link

codecov bot commented Jul 27, 2021 •
edited
Loading

Codecov Report

Merging #46 (a44b4ea) into main (969df66) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a44b4ea differs from pull request most recent head 6cfe473. Consider uploading reports for the commit 6cfe473 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##            main     #46      +/-   ##
========================================
- Coverage   0.02%   0.02%   -0.01%     
========================================
  Files         22      22              
  Lines       3507    3509       +2     
========================================
  Hits           1       1              
- Misses      3506    3508       +2
Impacted Files Coverage Δ
src/Turbulence_PrognosticTKE.jl 0.00% <0.00%> (ø)
src/Variables.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969df66...6cfe473. Read the comment docs.

@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 27, 2021
@bors @charleskawczynski
Merge #46
e634ece 
46: Use more grid abstractions r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 27, 2021

Build failed:

@charleskawczynski
Use more grid abstractions
6cfe473 
Use more grid abstractions
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 27, 2021

Build succeeded:

@bors bors bot merged commit afffafc into main Jul 27, 2021
@bors bors bot deleted the ck/grid_abstractions branch July 27, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
house cleaning 🧹 Refactor ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski