Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mse bug #460

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix mse bug #460

merged 1 commit into from
Oct 27, 2021

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 27, 2021 •
edited
Loading

I just saw that main broke because I forgot to consider the case where we don't have a new variable, but best_mse[tc_var] is a string, in which case we need to persist with using "NA". This was missed in #458.

@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 27, 2021

Build succeeded:

@bors bors bot merged commit 4243d5e into main Oct 27, 2021
@bors bors bot deleted the ck/bugfix branch October 27, 2021 18:05
@charleskawczynski charleskawczynski mentioned this pull request Oct 27, 2021
Merged
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
5b2b0c9 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
293853a 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @charleskawczynski
Merge #464
091e9e3 
464: Fix NA in print_new_mse r=charleskawczynski a=charleskawczynski

Closes #463. Thanks for catching this! This should have been incorporated in #459 / #460.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski referenced this pull request Nov 1, 2021
@bors @charleskawczynski
Merge #490
0f67537 
490: Bump version for new release r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski