Use OrdinaryDiffEq.jl for timestepping #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/ode
branch
2 times, most recently
from
e4d0d8d
to
c88579d
Compare
bors bot
added a commit
that referenced
this pull request
Oct 31, 2021
486: Make env diffusion explicit r=charleskawczynski a=charleskawczynski This PR changes the environmental diffusion to be treated explicitly in time. Similar to #485, this should help the transition to using OrdinaryDiffEq.jl for timestepping. Also, this is helpful because it removes the (decomposed) spatial operators. I've reduced the timestep in the drybubble case and rico. All of the results look good AFAICT, but the Hvar / QTVar prognostic variables look like they're severely diverging in ARM, Nieuwstadt, and DryBubble. We could further reduce the timestep (which I imagine would fix the problem), but I'm wondering if this is worthwhile since this doesn't technically affect our other results and we should (hopefully) go back to treating some terms implicitly once #473 merges. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski
force-pushed
the
ck/ode
branch
2 times, most recently
from
a48c881
to
93ece9b
Compare
charleskawczynski
force-pushed
the
ck/ode
branch
7 times, most recently
from
28f13db
to
5fb16ca
Compare
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
552: Change update interface, rename to step r=charleskawczynski a=charleskawczynski This is a prep PR for #473. This PR - renames `update` to `step!` - Changes the `step!` interface to be compatible with OrdinaryDiffEq.jl - Moves the `State` definition into TC.jl `src/`, so that we can pass its properties into a local struct and continue using the dycore API Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
552: Change update interface, rename to step r=charleskawczynski a=charleskawczynski This is a prep PR for #473. This PR - renames `update` to `step!` - Changes the `step!` interface to be compatible with OrdinaryDiffEq.jl - Moves the `State` definition into TC.jl `src/`, so that we can pass its properties into a local struct and continue using the dycore API Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
552: Change update interface, rename to step r=charleskawczynski a=charleskawczynski This is a prep PR for #473. This PR - renames `update` to `step!` - Changes the `step!` interface to be compatible with OrdinaryDiffEq.jl - Moves the `State` definition into TC.jl `src/`, so that we can pass its properties into a local struct and continue using the dycore API Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski
force-pushed
the
ck/ode
branch
7 times, most recently
from
177cd09
to
e498b57
Compare
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
554: Make diag dict field entry a state-accepting func r=charleskawczynski a=charleskawczynski This is a peel-off from #473. Basically, this PR changes the diagnostics dict field entry from a reference to the input state to a function that accepts the state. As a result, `io_dictionary_diagnostics`,`io_dictionary_aux`, etc. do not need the input state, and the dict acts in a more functional way. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Merged
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
555: Performance patch r=charleskawczynski a=charleskawczynski This is a peel off PR from #473. This PR adds a few ``@inbounds`` to some loops, and a performance patch for ClimaCore fields. See [ClimaCore.jl's 275](CliMA/ClimaCore.jl#275) Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
554: Make diag dict field entry a state-accepting func r=charleskawczynski a=charleskawczynski This is a peel-off from #473. Basically, this PR changes the diagnostics dict field entry from a reference to the input state to a function that accepts the state. As a result, `io_dictionary_diagnostics`,`io_dictionary_aux`, etc. do not need the input state, and the dict acts in a more functional way. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski
force-pushed
the
ck/ode
branch
from
34cc9e2
to
62b06b6
Compare
charleskawczynski
force-pushed
the
ck/ode
branch
from
62b06b6
to
977c355
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #270.