Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up, document LES driven forcing. #504

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Clean up, document LES driven forcing. #504

merged 1 commit into from
Nov 4, 2021

Conversation

ilopezgp
Copy link
Contributor

@ilopezgp ilopezgp commented Nov 3, 2021

I removed a few unused lines of code, improved naming of the tendencies and defined what these tendencies are following Shen et al (2021).

@ilopezgp ilopezgp force-pushed the cleanup_lesdscm branch 2 times, most recently from fd9d28e to 075bdd7 Compare November 3, 2021 16:18
@ilopezgp
Copy link
Contributor Author

ilopezgp commented Nov 3, 2021

I am a bit lost with the error messages here.

charleskawczynski
charleskawczynski approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine to me.

@ilopezgp
Copy link
Contributor Author

ilopezgp commented Nov 3, 2021

Code changes seem fine to me.

Do you know what is causing the tests to fail? It seems to be during plotting.

@trontrytel
Copy link
Member

trontrytel commented Nov 3, 2021 •
edited
Loading

Code changes seem fine to me.

Do you know what is causing the tests to fail? It seems to be during plotting.

Looks like some NaNs:

https://github.com/CliMA/TurbulenceConvection.jl/runs/4095155991?check_suite_focus=true#step:5:554

Bomex: Error During Test at /Users/runner/work/TurbulenceConvection.jl/TurbulenceConvection.jl/test/runtests.jl:20
  Got exception outside of a @test
  InexactError: trunc(Int64, NaN)
  Stacktrace:
    [1] trunc

Probably unrelated to this PR, because I'm seeing the same error in mine

@ilopezgp
Copy link
Contributor Author

ilopezgp commented Nov 4, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Build succeeded:

@bors bors bot merged commit 79dd173 into main Nov 4, 2021
@bors bors bot deleted the cleanup_lesdscm branch November 4, 2021 00:43
charleskawczynski referenced this pull request Nov 9, 2021
@bors @costachris
Merge #511
16fe6d1 
511: Use relaxation to LES profiles + define initial conditions more precisely for LES_driven_SCM r=costachris a=costachris

Addresses points 4, 7 from #505. 
Averages 1 hour window around `t_end` - 6 hours for initial conditions. `thetali` and `qt` are relaxed to the mean LES profile following eqn 9 in Shen et al. 2021


Co-authored-by: costachris <christopouloscosta@gmail.com>
charleskawczynski referenced this pull request Nov 9, 2021
@bors @charleskawczynski
Merge #545
2acfe47 
545: Bump version for new release r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@costachris costachris Awaiting requested review from costachris

@yairchn yairchn Awaiting requested review from yairchn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilopezgp @trontrytel @charleskawczynski