feat: add storage options to default_namelist
#525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakon-e
force-pushed
the
default_namelist_options
branch
3 times, most recently
from
bb9ddb4
to
261450f
Compare
charleskawczynski
approved these changes
Nov 6, 2021
There was a problem hiding this comment.
Looks fine to me. Since this is pretty high-level stuff, can we get a second reviewer. @ilopezgp, what do you think?
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2021
525: feat: add storage options to `default_namelist` r=haakon-e a=haakon-e In some cases I may want to 1. generate a default namelist for a case, without needing to saving it to file, or 2. specifying another location than `pwd` to store it to. This PR resolves both issues. Co-authored-by: Haakon Ludvig Langeland Ervik <45243236+haakon-e@users.noreply.github.com>
|
bors r- |
|
Canceled. |
haakon-e
force-pushed
the
default_namelist_options
branch
from
261450f
to
715b414
Compare
|
bors r+ |
|
Build succeeded: |
charleskawczynski
referenced
this pull request
Nov 9, 2021
511: Use relaxation to LES profiles + define initial conditions more precisely for LES_driven_SCM r=costachris a=costachris Addresses points 4, 7 from #505. Averages 1 hour window around `t_end` - 6 hours for initial conditions. `thetali` and `qt` are relaxed to the mean LES profile following eqn 9 in Shen et al. 2021 Co-authored-by: costachris <christopouloscosta@gmail.com>
charleskawczynski
referenced
this pull request
Nov 9, 2021
bors bot
added a commit
to CliMA/CalibrateEDMF.jl
that referenced
this pull request
Nov 24, 2021
87: refactor: run short simulation for reference SCM r=ilopezgp a=haakon-e Explicitly fetch/generate namelist from TC, then modify the time step in the namelist so that reference SCM simulation is only run 1 step forward. This generates the necessary z-levels, and cell/face variable info for calibration. Depends on CliMA/TurbulenceConvection.jl#525. TODO: Check that TC doesn't write namelist to output directory, otherwise all calibration studies will have incorrect `t_max`. Co-authored-by: Haakon Ludvig Langeland Ervik <45243236+haakon-e@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases I may want to
pwdto store it to.This PR resolves both issues.